Added StringPattern and made Automaton no longer borrow the query #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After removing `gradle-wrapper.jar` from being tracked in the repo you need to regenerate it manually when you clone the repo. To do that, you need `gradle` actually installed and then to run `gradle wrapper` in the correct directory. This was added to the README and to the benchmarks' `just init`. Additionally updated the root Justfile to also perform that during `init`.
…query The `Automaton` struct borrowed the source query, which also caused the Engine to carry the query's lifetime with it. The actual data being borrowed were the `JsonString` values for member transitions. In preparation for #117 we remove the borrowed `JsonString` and replace it with `StringPattern`. For UTF-8 the `StringPattern` will be a more complex struct that precomputes some stuff for efficient matching later. For now, it's a thin wrapper over a `JsonString`. During construction we may create many transitions over the same pattern. To reduce the size of the automaton we cache the patterns and put them into an `Rc`. This may get optimised later to instead use some kind of inline storage, but it's unlikely to actually matter. I ran the benchmarks and saw no measurable difference between the previous version and this one. Refs: #117 #613
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
The
Automatonstruct borrowed the source query, which also caused theEngine to carry the query's lifetime with it. The actual data being borrowed
were the
JsonStringvalues for member transitions.In preparation for #117 we remove the borrowed
JsonStringand replace itwith
StringPattern. For UTF-8 theStringPatternwill be a more complexstruct that precomputes some stuff for efficient matching later.
For now, it's a thin wrapper over a
JsonString.During construction we may create many transitions over the same pattern.
To reduce the size of the automaton we cache the patterns and put them
into an
Rc. This may get optimised later to instead use some kind ofinline storage, but it's unlikely to actually matter. I ran the benchmarks
and saw no measurable difference between the previous version and this one.
Issue
Resolves: #613
Checklist
All of these should be ticked off before you submit the PR.
just verifylocally and it succeeded.