-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common flags and options #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
rsore
force-pushed
the
common-parameters
branch
from
October 22, 2024 19:59
5bbb3c5
to
e23f506
Compare
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A lot of programs support the same basic flags and options, for exampe "--help", "--verbose" and "--input ". It makes sense for the library to offer a set of these basic flags and options ready for use so users don't necessarily have to create custom flags and options for everything. They can simply be added to the parser builder and used directly:
Related Issues
Closes #32.
How Has This Been Tested?
I implemented tests for all common flags and options I added. The tests themselves do not check behavior in cases like ill-formed values or unknown arguments, these are already handled in other tests. Instead, these simply focus on verifying that the flag and option types can be used with the parser, and that the values are properly set for any of their supported identifiers.