-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for React <18 #34
Comments
It should work. Could you try the sandbox demo in a new repository as multi-version React in a monorepo is a mess. |
@fi3ework here is the replicate of the repo I used for testing. Unfortunately I couldn't get the sandbox to run because storybook thinks the port is taken, but you should be able to access my code and reproduce it locally. I don't do anything specific, just change the React version to 17. As soon as the compatibility with 8.2 is fixed I can test it out. |
I've located where's wrong. Fixing that. |
Fixed in 0.0.7. |
Just tested it, it works like a charm! I will update the repo I posted in the thread. Thank you for your help! ❤️ |
Right now, there is a problem when trying to use a version that is lower than 18.
I believe that if used correctly,
@storybook/react-dom-shim
will target the correct React DOM import (react-dom
instead ofreact-dom/client
).Reproduction
From the
/sandboxes/react-rsbuild
, change the React version to 16 or 17.The text was updated successfully, but these errors were encountered: