Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: works with react <= 18 #38

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: works with react <= 18 #38

merged 1 commit into from
Jul 12, 2024

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Jul 12, 2024

Fix #34 by adding react-dom-shim. Since @storybook/react-dom-shim doesn't export rsbuildFinal and using webpackFinal may introduce too much unexpected config. So I forked preset of react-dom-shim.

@fi3ework fi3ework merged commit 6f42fa8 into main Jul 12, 2024
2 checks passed
@fi3ework fi3ework deleted the 18 branch July 12, 2024 19:01
fi3ework added a commit that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for React <18
1 participant