Stack traces are invisible in some color schemes

[garybernhardt]

In the solarized terminal/editor color scheme, RSpec stack traces are invisible. This seems to happen because RSpec stack traces are always black, so they don't show up against a black background. They're visible in solarized light (http://i.imgur.com/VFPhp.png) but not solarized dark (http://i.imgur.com/FJ6dm.png).

[justinko]

It should be grey (mine is). What is your system info?

[garybernhardt]

I'm running a standard solarized theme. It happens in both iTerm and Terminal under Snow Leopard. In April, this was reported as a bug to solarized itself, but fixing it there would require changing the colors, which the author isn't willing to consider. Here's the solarized issue: altercation/solarized#66.

[dchelimsky]

I just installed solarized and it comes out gray for me too: http://i.imgur.com/uXTYY.png. This is in Terminal.app on Snow Leopard.

I wonder if we installed it the same way. In followed the instructions on https://github.com/altercation/solarized/blob/master/osx-terminal.app-colors-solarized/README.md: I already had SIMBL installed, I installed https://github.com/timmfin/terminalcolours, and then installed the solarized themes by simply opening them from Terminal. @garybernhardt - have you taken the same (or similar) steps?

[dchelimsky]

BTW, @garybernhardt - I hadn't taken the time to install solarized before this, so regardless of our solution to your issue, I thank you for the impetus.

[garybernhardt]

I just updated to RSpec 2.6.3, reinstalled the latest SIMBL and TerminalColors, deleted the schemes from Terminal, recreated from the solarized .terminal files, and got the same result.

Poking into RSpec, I see this at lib/rspec/core/formatters/base_text_formatter.rb:122:

def grey(text)
  color(text, "\e[90m")
end

This is what's used for tracebacks, and 90m is high-intensity ("bright") black. In my solarized scheme, bright black is #042028, which is identical to the background color. What colors do you have for bright black and background?

[dchelimsky]

Where did you look up the background color in your solarized sheme? I opened up Solarized Dark ansi.terminal and I see what looks like sha1 hashes. Opened it up in Property List Editor and that wasn't any better.

I also don't understand the relationship between the colors set by rspec and the colors that show up. I went in and changed grey to "\e[61m]" (and 70 and 49, which were all diff values I got by searching for 'ansi grey') and they all looked the same when I ran specs.

[dchelimsky]

I wonder if there is a setting in Terminal that you have that I don't have?

[garybernhardt]

You can see the exact colors for your terminal profile by hitting "More..." on the profile's Text tab. The values I mentioned directly from the scheme came from the bottom of https://github.com/altercation/solarized/blob/master/osx-terminal.app-colors-solarized/README.md.

[dchelimsky]

I don't have a "More ..." button on the profile's Text tab, or anywhere in the UI. We must have different versions. I'm on OSX 10.6.7 - you?

[garybernhardt]

Oh! I don't think your TerminalColors is working then. The "More..." button is what TerminalColors adds. This would explain why your colors are less varied than mine.

Is your TerminalColors*.bundle in ~/Library/Application Support/SIMBL/Plugins? Also, note that if you start Terminal by opening a .terminal file, rather than starting the app directly, then TerminalColors' button doesn't show up.

[dchelimsky]

@garybernhardt - thank you! I have now been able to reproduce and will get in a fix over the weekend.

[garybernhardt]

Awesome! Thanks, man. :)