Skip to content
This repository has been archived by the owner on Nov 30, 2024. It is now read-only.

Introduce full_cause_backtrace configuration #3046

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

davidtaylorhq
Copy link
Contributor

By default, RSpec only prints the first line of a 'caused by' backtrace. This commit introduces a new 'full_cause_backtrace' config option which will enable printing the entire cause backtrace.

This feature has previously been requested and discussed in #3027. The outstanding questions there were:

  • whether the config should be a boolean or an enum. Here I have implemented it as a boolean.
  • if/how to expose this on the CLI. I have omitted this entirely, but am happy to work on this if it's a pre-requisite for merging

Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 thanks for this, the implementation looks fine but you need to tweak it slightly to satisfy our rubocop rules

davidtaylorhq and others added 2 commits January 26, 2024 01:50
By default, RSpec only prints the first line of a 'caused by' backtrace. This commit introduces a new 'full_cause_backtrace' config option which will enable printing the entire cause backtrace.
@pirj pirj force-pushed the full-cause-backtrace branch from d877297 to fd2c2f5 Compare January 25, 2024 22:56
@pirj pirj merged commit 236405c into rspec:main Jan 25, 2024
29 of 30 checks passed
@pirj
Copy link
Member

pirj commented Jan 25, 2024

Thank you, @davidtaylorhq !

@JonRowe
Copy link
Member

JonRowe commented Feb 4, 2024

Released in 3.13.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants