Skip to content
This repository has been archived by the owner on Nov 30, 2024. It is now read-only.

Fix the build by relaxing rubocop rule #3122

Merged
merged 2 commits into from
Nov 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,10 @@ elsif RUBY_VERSION < '2.0'
gem 'ffi', '< 1.9.19' # ffi dropped Ruby 1.8 support in 1.9.19
elsif RUBY_VERSION < '2.3.0'
gem 'ffi', '~> 1.12.0'
else
elsif RUBY_VERSION < '2.6.0'
gem 'ffi', '~> 1.15.0'
else
gem 'ffi', '~> 1.17.0'
end

if RUBY_VERSION < '2.3.0' && !!(RbConfig::CONFIG['host_os'] =~ /cygwin|mswin|mingw|bccwin|wince|emx/)
Expand Down
5 changes: 5 additions & 0 deletions lib/rspec/core/formatters/exception_presenter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@ module Formatters
class ExceptionPresenter
attr_reader :exception, :example, :description, :message_color,
:detail_formatter, :extra_detail_formatter, :backtrace_formatter

# We want private attr_reader but that issues a warning on older rubies, refactor later
#
# rubocop:disable Style/AccessModifierDeclarations
private :message_color, :detail_formatter, :extra_detail_formatter, :backtrace_formatter
# rubocop:enable Style/AccessModifierDeclarations

def initialize(exception, example, options={})
@exception = exception
Expand Down
Loading