Revert "Improve change mather detection of objects that have change…

…d. (#1132)"

This reverts commit 443212a.

lib/rspec/matchers/built_in/change.rb

@@ -367,16 +367,13 @@ def value_representation
         def perform_change(event_proc)
           @actual_before = evaluate_value_proc
           @before_hash = @actual_before.hash
-          @before_attribute_hashes = calculate_attribute_hashes(@actual_before)
-
           yield @actual_before if block_given?
 
           return false unless Proc === event_proc
           event_proc.call
 
           @actual_after = evaluate_value_proc
           @actual_hash = @actual_after.hash
-          @after_attribute_hashes = calculate_attribute_hashes(@actual_after)
           true
         end
 
@@ -393,9 +390,7 @@ def changed?
           # possible for two values to be unequal (and of different classes)
           # but to return the same hash value. Also, some objects may change
           # their hash after being compared with `==`/`!=`.
-          @actual_before != @actual_after ||
-          @before_hash != @actual_hash ||
-          @before_attribute_hashes != @after_attribute_hashes
+          @actual_before != @actual_after || @before_hash != @actual_hash
         end
 
         def actual_delta
@@ -404,14 +399,6 @@ def actual_delta
 
       private
 
-        # methods are stashed to ensure we get access to variables on modified classes / BasicObject
-        OBJECT_VARIABLES = Object.instance_method(:instance_variables)
-        OBJECT_VARIABLE_GET = Object.instance_method(:instance_variable_get)
-
-        def calculate_attribute_hashes(object)
-          OBJECT_VARIABLES.bind(object).call.map { |name| OBJECT_VARIABLE_GET.bind(object).call(name).hash }
-        end
-
         def evaluate_value_proc
           @value_proc ? @value_proc.call : @receiver.__send__(@message)
         end

spec/rspec/matchers/built_in/change_spec.rb

@@ -368,10 +368,6 @@ def self.to_s
     expect { @instance.some_value = 6 }.to change { @instance.some_value }
   end
 
-  it "passes when actual has a value modified" do
-    expect { @instance.some_value = 6 }.to change { @instance }
-  end
-
   it "fails when actual is not modified by the block" do
     expect do
       expect {}.to change { @instance.some_value }