add support for recognizing mailer many jobs: #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
got lucky with rubocop new release, which break CI.. opened #2126 to fix CI.. will rebased this branch after CI is fixed.. |
Can we close is then? |
benoittgt
reviewed
May 13, 2019
ignatiusreza
force-pushed
the
mailer-job
branch
2 times, most recently
from
16a6605
to
6d895ff
Compare
JonRowe
requested changes
May 14, 2019
| @@ -63,20 +68,18 @@ def expected_count_message | |||
| "#{message_expectation_modifier} #{@expected_number} #{@expected_number == 1 ? 'time' : 'times'}" | |||
| end | |||
|
|
|||
| def mailer_args | |||
| def job_match?(job) | |||
| MAILER_JOBS.any? { |mailer_job| send(mailer_job, job) } | |||
There was a problem hiding this comment.
I think I'd rather we just called legacy_mail?(mailer_job, job) || parameterized_mail?(mailer_job, job) || unified_mail?(mailer_job, job) rather than constantising it and iterating.
There was a problem hiding this comment.
sure, updated.. I used constant because I thought it would be easier later IF we somehow need to add check for other job..
- parameterized mailer when RAILS_VERSION >= 5.1 - unified mailer job when RAILS_VERSION >= 6.0
JonRowe
approved these changes
May 15, 2019
|
@samphippen are you ok to merge this? 😊 |
benoittgt
added a commit
that referenced
this pull request
May 18, 2019
benoittgt
pushed a commit
that referenced
this pull request
Aug 21, 2019
benoittgt
added a commit
that referenced
this pull request
Aug 21, 2019
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
Aug 24, 2019
benoittgt
added a commit
to benoittgt/rspec-rails
that referenced
this pull request
Aug 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #2117 (comment)
this PR supersede #2121 with added support for recognizing
ActionMailer::MailDeliveryJobfreshly added into rails 6.0