Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tagged_logger by hand #2625

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Oct 14, 2022

Similar to #2461, rather than use Rails modules verbatim, vendor the import part of what they do (in this case define the private tagged_logger method) so we have less of an overlap. In particular the actual module does this:

def before_setup
  if tagged_logger && tagged_logger.info?
    heading = "#{self.class}: #{name}"
    divider = "-" * heading.size
    tagged_logger.info divider
    tagged_logger.info heading
    tagged_logger.info divider
  end
  super
end

Which is what is causing issues for #2624

@JonRowe JonRowe marked this pull request as draft October 14, 2022 08:00
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much better, thank you!

magni- added a commit to magni-/rspec-rails-dummy that referenced this pull request Oct 17, 2022
@JonRowe JonRowe merged commit 0482ca2 into main Oct 17, 2022
@JonRowe JonRowe deleted the replacement-tagged-logger-support branch October 17, 2022 11:06
JonRowe added a commit that referenced this pull request Oct 17, 2022
JonRowe added a commit that referenced this pull request Oct 17, 2022
JonRowe added a commit that referenced this pull request Oct 17, 2022
@JonRowe
Copy link
Member Author

JonRowe commented Oct 18, 2022

This has been released in 6.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants