Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 7.2 to CI matrix #2778

Merged
merged 5 commits into from
Aug 10, 2024
Merged

Add Rails 7.2 to CI matrix #2778

merged 5 commits into from
Aug 10, 2024

Conversation

pirj
Copy link
Member

@pirj pirj commented Aug 10, 2024

@pirj pirj self-assigned this Aug 10, 2024
This causes a file generation conflict in Rails 7.2, as they seem to
already exist. We don't want to overwrite whatever there is.

```
    conflict    app/assets/config/manifest.js
  Overwrite /Users/pirj/source/rspec-dev/repos/rspec-rails/tmp/example_app/app/assets/config/mani
  Overwrite /Users/pirj/source/rspec-dev/repos/rspec-rails/tmp/example_app/app/assets/config/manifest.js? (enter "h" for help) [Ynaqdhm] y
       force    app/assets/config/manifest.js
    conflict    app/assets/stylesheets/application.css
  Overwrite /Users/pirj/source/rspec-dev/repos/rspec-rails/tmp/example_app/app/assets/stylesheets
  Overwrite /Users/pirj/source/rspec-dev/repos/rspec-rails/tmp/example_app/app/assets/stylesheets/application.css? (enter "h" for help) [Ynaqdhm] y
       force    app/assets/stylesheets/application.css
```
@pirj pirj marked this pull request as ready for review August 10, 2024 17:29
@pirj pirj requested a review from JonRowe August 10, 2024 17:29
@pirj
Copy link
Member Author

pirj commented Aug 10, 2024

The easiest update on my memory. I intend to merge straight away because no changes were required.

I've restarted the 3.0 x 7.0 build job, and it passed on the second attempt. I couldn't bundle locally, plenty of gems failed to compile with -Wint-conversion e.g. for sqlite3:1.4.4 (M3, mise/rbinstall). I'm uncertain why our build attempts to install that version, since we specify the dependency as '~> 1.4' 🤔 . It may need further research, but seems unrelated to this PR.

@pirj pirj merged commit 9f4a5de into main Aug 10, 2024
21 checks passed
@pirj pirj deleted the add-rails-7.2-to-matrix branch August 10, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant