Run specs for warning helpers in sub process #6
Conversation
| end | ||
| def run_with_rspec_core | ||
| in_sub_process do | ||
| require 'rspec/support/warnings' |
There was a problem hiding this comment.
This require concerns me, because the spec suite for this gem could grow to the point where this file is required elsewhere, and this would be come a no-op. Have you considered using load instead?
|
I'm worried that we're creating a circular dependency here: rspec-core depends on this gem, and this gem now implicitly depends on rspec-core, and that could create a maintenance headache. (Consider, for example, what happens when we decide to change the deprecation formatter API: we'll have to coordinate changes in rspec-core and rspec-support). Do you think there's a reasonable way to get this to work that doesn't involve creating that circular dependency? For example, maybe this gem could just define the core-less version of these methods, and then core can override those definitions. Or here it could define the methods only if Thoughts? |
Run specs for warning helpers in sub process
|
(Note I'm merging this because it doesn't relate to your concerns directly, I'm going to pull those into a new issue) |
No description provided.