Fix mutation strategy when loaded async #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use correct element name * also mount elements in DOM when page is already loaded
morbidick
force-pushed
the
fix-mutation-strategy
branch
from
4a0d9a9 to
c1728fd
Compare
rstacruz
approved these changes
Sep 22, 2022
|
Makes sense! Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thank you very much for this awesome project! We started using it at our company and it helps us a lot with our micro frontend approach. We found two bugs in the Mutation Observer Strategy (sadly we still have to provide IE11 support ;) )