Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retarget React events in Shadow DOM mode #8

Merged
merged 9 commits into from
Apr 21, 2019
Merged

Retarget React events in Shadow DOM mode #8

merged 9 commits into from
Apr 21, 2019

Conversation

rybon
Copy link
Contributor

@rybon rybon commented Apr 18, 2019

Fixes #5.

@rybon rybon changed the title Retarget React events Retarget React events in Shadow DOM mode Apr 18, 2019
@rybon
Copy link
Contributor Author

rybon commented Apr 18, 2019

@rstacruz could you review?

@rstacruz
Copy link
Owner

:o Thank you for this! Having a look now.

rstacruz
rstacruz approved these changes Apr 21, 2019
View reviewed changes
docs/api.md
```

**NOTE:** When using this feature `event.nativeEvent` is no longer present in React event handlers.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking time to update the documentation!

@rstacruz rstacruz merged commit 194ae2a into rstacruz:master Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstacruz rstacruz rstacruz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mapping of events down to custom element
2 participants
@rybon @rstacruz