-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 18 support #81
React 18 support #81
Conversation
6897563
to
376bab4
Compare
@lreddickGNA Did you get a chance to test this? :-) |
Tests are a bit of a mess and doesn't even run on CI :( Addressing that in a separate PR: |
@rstacruz awesome stuff! When do you think the new version will be published to npm? |
Unfortunately I'm having trouble with my npm account at the moment so I'm not sure :( |
Btw, caveat - React 18 stopped supporting IE11, so Remount v0.11 will be the last version to support IE11. Releases after that will not officially support IE11. There's still code in Remount to support IE11 for now, simply because we haven't had a chance to remove them yet (eg, the mutationobserver workaround because IE11 has no web components support). Presumably we'll be removing those bits as we go. Related links: |
Published a pre-release as EDIT: now out as remount@1.0.0 - https://github.com/rstacruz/remount/releases/tag/v1.0.0 |
@rstacruz awesome! I will update our project package json to reflect the new release! |
Thanks lreddickGNA for starting this with #80! This is a re-implementation of his PR to add React 18 support, but without removing the custom adapter support.