Add a vectorized wrapper for xfun::relative_path #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to handle several inputs in render_book()
yihui
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
Other solution would be to make
xfunfunctions vectorized.
Yes. I'll merge this PR for now and think about it later.
This type of situation make me feels we are trying to recreate / maintain / tests some functionality we could get elsewhere
It's always a trade-off between introducing new dependencies and maintaining one's own code. If the latter is not too complicated, I tend to go the latter way. fs does contain a huge set of functions about file paths, but I only need a very small subset of it.
Thanks!
|
FYI |
clrpackages
pushed a commit
to clearlinux-pkgs/R-xfun
that referenced
this pull request
Mar 16, 2021
Yihui Xie (22):
use exit_call(), and return early if stringsAsFactors is already false
clarify the title, since not all functions are written by me
vectorize relative_path(): rstudio/bookdown#1091
use tinytex::is_tinytex() since v0.30 is on CRAN now
update license year
don't override the env var R_LIBS_USER if it has been set
read both ~/.Renviron and .Renviron
factor out path_sep()
if no package is left after ignoring specified packages, return early
when rechecking packages, make sure their dependencies are installed
add a function to help clean up a dir that contains binary packages built with an older major version of R
always return the names of broken packages
add functions to query Homebrew dependencies of R packages
add a function `retry()` to retry calling a function for a number of times in case of errors
also split package names by spaces, e.g., "pandoc pandoc-citeproc" -> c("pandoc", "pandoc-citeproc")
use tools::write_PACKAGES() instead of write.dcf() (to also update PACKAGES.gz/.rds)
fix rstudio/tinytex#286: increase the timeout to 3600 seconds in download_file()
add a function sort_file() to sort text lines in a file
the argument `FUN` was renamed to `fun` in `process_file()`; this is for consistency with other functions like retry() and exit_call(), but might be a breaking change (if that's the case, I may revert this change)
factor out the code to read sysreqsdb.rds
use known dependencies instead of querying every time
CRAN release v0.22
christophe dervieux (1):
typo in on.exit() help page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle several inputs in
render_book(input=). Currently it seems to work but we have warnings thrown inxfun::relative_pathReported in #1090
Other solution would be to make
xfunfunctions vectorized. @yihui would that be better ?This type of situation make me feels we are trying to recreate / maintain / tests some functionality we could get elsewhere : fs package is rather low level with no dependency and could help power all the path handling in the packages. Just throwing the idea in case this is a project we want to tackle.