Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract out connection code into own method #137

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Extract out connection code into own method #137

merged 3 commits into from
Jan 31, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Jan 30, 2024

Part of #94

Tested with

library(chromote)

chrome <- default_chromote_object()
str(chrome$SystemInfo$getProcessInfo())

# SLEEP

str(chrome$SystemInfo$getProcessInfo())
# Errors

chrome$connect()
str(chrome$SystemInfo$getProcessInfo())
# works

@hadley hadley requested a review from wch January 30, 2024 14:46
wch
wch reviewed Jan 30, 2024
View reviewed changes
R/chromote.R Outdated Show resolved Hide resolved
wch
wch reviewed Jan 30, 2024
View reviewed changes
R/chromote.R Outdated Show resolved Hide resolved
hadley and others added 2 commits January 30, 2024 17:59
@hadley @wch
Doc improvements
07a4ab3 
Co-authored-by: Winston Chang <winston@posit.co>
@hadley
devtools::document() (GitHub Actions)
b3819d5
@hadley hadley merged commit c4415ff into main Jan 31, 2024
1 check passed
@hadley hadley deleted the reconnect branch January 31, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadley @wch