-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a selection box appearing only on double click #58
Comments
@schloerke, do you mind investigating? Seems likely to be in leaflet? |
The leaflet map when it is made without shiny works as expected. With shiny, the map is being redrawn multiple times. When you "click" and it selects data for the first time, it glitches as if it was reset is when the map is being redrawn. This glitch only happens when something within the data is being set. (The second click would not select new data, so it would work as expected.) I believe the shared data is not being set properly (and causing a trigger to draw the map), as shinyreactlog is trying to depend on some shared data node that doesn't exist. Somewhere in these set of commits: https://github.com/schloerke/shiny/compare/barret/reactlog...schloerke:barret-reactlog-merge?expand=1 is a change that is causing the issue. (barret/reactlog works as expected, barret-reactlog-merge contains the latest master from shiny) The reactlog graph looks like: Lines 249 to 256 in 1c67fbf
The reactlog graph on a working as expected branch (schloerke/shiny - barret/reactlog) looks like: |
Issue merged into rstudio/leaflet master branch. @pythiantech Please let me know if you can still see the map resetting devtools::install_github("rstudio/leaflet")
### example code - Barret |
@schloerke @jcheng5 Thanks, working fine now! |
… 2.0.3 leaflet 2.0.3 -------------------------------------------------------------------------------- BREAKING CHANGES * `data("providers")` and `data("providers.details")` no longer exist. Please use `leaflet::providers` and `leaflet::providers.details`. (#636) BUG FIXES and IMPROVEMENTS * Integrated data from `leaflet.providers` package. See [leaflet.providers](https://rstudio.github.io/leaflet.providers/) for details. (#636) * Fixed [rstudio/crosstalk#58](rstudio/crosstalk#58), which caused Leaflet maps that used Crosstalk shared data in Shiny apps, to be redrawn at incorrect times. * invokeRemote() now resolves html dependencies before passing them to shiny::createWebDependency() (#620). * Upgrade leaflet-provider to 1.4.0, enable more map variants such as CartoDB.Voyager (#567) * `sf` objects with `names` attributes in the `st_geometry` now visualise correctly (#595) * GeoJSON objects missing `properties` can now be displayed (#622)
While running a shiny application, the 'make a selection' box does not appear until you double click on the icon. Thereafter if you resize it, it disappears again. I have tried this in both Firefox and Chrome.
Here's the code I am using:
Here's the
df
data:I am on a MacBook Pro (macOS High Sierra Version 10.13.6)
The text was updated successfully, but these errors were encountered: