Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize vec_*() error messages with check_vector_valid() #1662

Merged
merged 7 commits into from
May 14, 2024
Merged

Standardize vec_*() error messages with check_vector_valid() #1662

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9551eb0
check `x` first
olivroy May 13, 2024
abeee7a
Add minimal test for `vec_fmt_duration()` + rephrase `input_units` er…
olivroy May 13, 2024
0b2dae6
Move `x` validation tests in a separate test.
olivroy May 13, 2024
c01d858
Create `check_vector_valid()`, Remove `vector_class_is_valid()` and `…
olivroy May 13, 2024
a6b9e0c
Fix typo `.object_type_friendly` -> `.obj_type_friendly`
olivroy May 13, 2024
292ecb9
Add back validation for `vec_fmt_markdown()` and style `check_vector_…
olivroy May 13, 2024
7d18105
Merge branch 'master' into vec-error
rich-iannone May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/format_data.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7580,8 +7580,8 @@ fmt_duration <- function(
is.null(input_units)
) {
cli::cli_abort(c(
"When there are numeric columns to format, `input_units` must not be `NULL`.",
"*" = "Use one of \"seconds\", \"minutes\", \"hours\", \"days\", or \"weeks\"."
"{.arg input_units} must be supplied when there are numeric columns to format.",
"i" = "Use one of \"seconds\", \"minutes\", \"hours\", \"days\", or \"weeks\"."
))
}

Expand Down
Loading
Loading