Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Augment RSC chart to have a secret config #80

Open
colearendt opened this issue Nov 8, 2021 · 1 comment · May be fixed by #132
Open

Augment RSC chart to have a secret config #80

colearendt opened this issue Nov 8, 2021 · 1 comment · May be fixed by #132
Labels
rsc

Comments

@colearendt
Copy link
Contributor

colearendt commented Nov 8, 2021 •
edited
Loading

Secrets are right now stored in the configmap with the rest of the server configuration. We should allow configuring secrets in a secret, and passing multiple files to the Connect executable, so that secrets are handled more properly

Related to #44
@colearendt
Copy link
Contributor Author

Started digging into this, but will need to modify the docker images for this to work - we need to be able to add arguments to the /usr/local/bin/startup.sh invocation of Connect here:

https://github.com/rstudio/rstudio-docker-products/blob/853fcf6d7f9ea3a452e90f2152fefc5419d85a99/connect/startup.sh#L28

That raises the question: should we just append args onto what we have, or set the default args to include --config /etc/rstudio-connect/rstudio-connect.gcfg and remove that from being invoked directly. This has the downside of being a more invasive / breaking change (so we would want to couple it to a product version bump), but has the advantage of allowing users of the image to customize where they put their configuration file... 🤷‍♂️

@colearendt colearendt linked a pull request Jan 4, 2022 that will close this issue
Draft
@colearendt colearendt added the rsc label Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rsc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a basic secretConfig value rstudio/helm
1 participant
@colearendt