Set 0600 fileMode for rstudio-connect.gcfg #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronatkins
approved these changes
Aug 27, 2021
| @@ -163,6 +163,7 @@ spec: | |||
| - name: rstudio-connect-config | |||
| configMap: | |||
| name: {{ include "rstudio-connect.fullname" . }}-config | |||
| defaultMode: 0600 | |||
There was a problem hiding this comment.
This seems to change the permissions for everything in the configMap, including the runtime.yaml and the JSON overrides. Is that OK?
There was a problem hiding this comment.
Great catch. We'll have to split those out into a separate configmap if we want to make this change. Unfortunately you can only set the defaultMode on the volume not on the volumeMount where we define the subPath
This was referenced Nov 8, 2021
|
This has fallen pretty far behind so I'm going to close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #42