Fix posit-chronicle to function with default values #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not particularly involved in any chart maintenance; I set up the documentation site. |
… Mark Tucker is the lead for chronicle so I'm adding him instead
Removed! |
|
Thanks @jforest! You can also include @markrtucker and @t-margheim in this. |
|
I believe Ashley's involvement was also primarily docs-related. |
|
At https://github.com/rstudio/helm/tree/main/charts/posit-chronicle#storage-configuration we say the default is local storage, so this is changing the code to match the documentation 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial error with the empty values file is:
Error: failed to create metrics service: no storers found for v1/metricsSetting
LocalStorage.Enabledtotruefixes the empty values file problemI also added a few more CODEOWNERS. I made some guesses on who makes sense for which based on who has made commits to those charts, and those who I am fairly sure are involved.
So, sorry @matt-urbina @markrtucker @AshleyHenry15 @GCRev and @zachhannum if you are not the proper people. If you could give me some better names I will be happy to update the lists