Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tag() in C #416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement tag() in C #416

wants to merge 1 commit into from

Conversation

mgirlich
Copy link

Supersedes #414.

I think it is worth implementing tag() in C to make it fast. Especially when using tag() directly instead of tags$... this is now quite fast.

library(htmltools)

set.seed(1)
n <- 50e3
data <- vroom::gen_character(n)

f_tags <- function(data) {
  for (i in seq_along(data)) {
    tags$tr(data[[i]])
  }
}
f_tag <- function(data) {
  for (i in seq_along(data)) {
    tag("tr", list(data[[i]]))
  }
}

bench::mark(
  tags = f_tags(data),
  tag = f_tag(data),
)

# before
# # A tibble: 2 × 13
#   expression      min   median `itr/sec` mem_alloc `gc/sec`
#   <bch:expr> <bch:tm> <bch:tm>     <dbl> <bch:byt>    <dbl>
# 1 tags          1.24s    1.24s     0.810    41.2KB     13.0
# 2 tag        637.34ms 637.34ms     1.57     15.2KB     14.1

# after
# # A tibble: 2 × 13
#   expression      min  median `itr/sec` mem_alloc `gc/sec` n_itr
#   <bch:expr> <bch:tm> <bch:t>     <dbl> <bch:byt>    <dbl> <int>
# 1 tags        426.8ms   441ms      2.27    15.7KB     29.5     2
# 2 tag          89.8ms    91ms     10.8     15.2KB     43.3     6

SEXP new_tag(SEXP tagName, SEXP varArgs, SEXP noWS, SEXP renderHook) {
R_xlen_t n = Rf_xlength(varArgs);

// TODO validate that varArgs is a list
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is documented that varArgs must be a list but there is a test where this is not the case. Should we allow varArgs to be e.g. a character and simply wrap it in a list?

@@ -386,6 +386,7 @@ test_that("Old tags predating rlang::list2 can still be rendered", {
})

test_that("tag with noWS works",{
skip("should tag accept only lists?")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant