Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Minor tweaks + use roxygen Markdown + bring dev mod auto. #911

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Mar 27, 2024

Also fix #910.

Enabling roxygen markdown doc with usethis::use_roxygen_md() will help a little. I didn't run roxygen2md::roxygen2md() because the diff would have gotten too big.

I couldn't really find how to download directly.

Error in ncdf4::nc_open(filename, readunlim = FALSE, suppress_dimvals = TRUE) : 
Error in nc_open trying to open file https://rstudio.github.io/leaflet/nc/oisst-sst.nc (return_on_error= FALSE )

@schloerke
Copy link
Contributor

I didn't run roxygen2md::roxygen2md() because the diff would have gotten too big.

If this is an automated call, I'd be up for an isolated PR with a single commit of just the changes from the auto conversion.

Could it be a follow up PR? Or does it need to happen before this one?

If it looks too crazy, we can back out... but I'm still curious.

@schloerke
Copy link
Contributor

I am sorry about the windows install failures. I'll try to fix that tomorrow. Looks like it's trying to install tools 4.2 when it needs 4.3

@olivroy
Copy link
Contributor Author

olivroy commented Mar 28, 2024

I didn't run roxygen2md::roxygen2md() because the diff would have gotten too big.

If this is an automated call, I'd be up for an isolated PR with a single commit of just the changes from the auto conversion.

Could it be a follow up PR? Or does it need to happen before this one?

If it looks too crazy, we can back out... but I'm still curious.

I can do follow-up ! It is mostly automated, but requires some clean-up afterwards. But never a good idea to mix opinionated changees with automated ones as they can get lost!

@schloerke schloerke merged commit ff7fae2 into rstudio:main Apr 2, 2024
12 of 13 checks passed
@olivroy olivroy mentioned this pull request Apr 2, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove vignettes/articles/nc after successful site build
2 participants