Skip to content

Commit

Permalink
Remove "Correct!" from random_praise()
Browse files Browse the repository at this point in the history
  • Loading branch information
gadenbuie committed Jan 4, 2021
1 parent 4b9cc8a commit 529ddde
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ learnr (development version)
## Breaking Changes

* Renamed the `exercise_submission` event to `exercise_result` and added the following fields:
1. `id` - a randombly generated identifier that can be used to align with the associated `exercise_result` event.
1. `id` - a randomly generated identifier that can be used to align with the associated `exercise_result` event.
2. `time_elapsed` - the time required to run the exercise (in seconds)
3. `timeout_exceeded` - indicates whether the exercise was interrupted due to an exceeded timeout. May be `NA` for some platforms/evaluators if that information is not known or reported. ([#337](https://github.com/rstudio/learnr/pull/337))
* If a `-code-check` chunk returns feedback for an exercise submission, the result of the exercise is no longer displayed for a correct answer (only the feedback is displayed). If both the result and feedback should be displayed, all checking should be performed in a `-check` chunk (i.e., don't provide a `-code-check` chunk). ([#403](https://github.com/rstudio/learnr/pull/403))
* `random_praise()` no longer includes the phrase _Correct!_. Instead, it returns a random praising statement. ([#462](https://github.com/rstudio/learnr/pull/403), [#453](https://github.com/rstudio/learnr/issues/453))

## New features

Expand Down
2 changes: 1 addition & 1 deletion R/praise.R
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ random_encouragements <- c(
#' @export
#' @rdname random_praise
random_praise <- function() {
paste0("Correct! ", sample(random_praises, 1))
sample(random_praises, 1)
}
#' @export
#' @rdname random_praise
Expand Down

0 comments on commit 529ddde

Please sign in to comment.