Skip to content

Commit

Permalink
v0.10.0 (#271)
Browse files Browse the repository at this point in the history
* add revdep checks

* fix missing var from bad merge

* bump version to v0.10.0

* run revdep

* remove remotes for checking

* rerun revdep

* Use cran comments

* spelling

* Remove completed TODO-barret 's

* document

* fix link

* ignore cran-release
  • Loading branch information
schloerke committed Nov 12, 2019
1 parent c41c381 commit a47a7e0
Show file tree
Hide file tree
Showing 13 changed files with 78 additions and 42 deletions.
3 changes: 3 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,7 @@
rsconnect/
^\.github/
^inst/tutorials/.*\.html$
^revdep$
^LICENSE\.md$
^cran-comments\.md$
^CRAN-RELEASE$
5 changes: 1 addition & 4 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: learnr
Type: Package
Title: Interactive Tutorials for R
Version: 0.9.2.9006
Version: 0.10.0
Authors@R: c(
person("Barret", "Schloerke", role = c("aut", "cre"), email = "barret@rstudio.com",
comment = c(ORCID = "0000-0001-9986-114X")),
Expand Down Expand Up @@ -33,12 +33,9 @@ Imports:
markdown,
shiny (>= 1.0),
rmarkdown (>= 1.12.0),
packrat (>= 0.5.0-7),
ellipsis (>= 0.2.0.1),
checkmate,
renv (>= 0.8.0)
Remotes:
rstudio/packrat
Encoding: UTF-8
LazyData: true
Roxygen: list(markdown = TRUE)
Expand Down
4 changes: 2 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
learnr 0.10.0 (unreleased)
learnr 0.10.0
===========

## New features
Expand All @@ -11,7 +11,7 @@ learnr 0.10.0 (unreleased)

* Added the last evaluated exercise submission value, `last_value`, as an exercise checker function argument. ([#228](https://github.com/rstudio/learnr/pull/228))

* Added tabset support. ([#219](https://github.com/rstudio/learnr/pull/219) [#213](https://github.com/rstudio/learnr/issues/213))
* Added tabset support. ([#219](https://github.com/rstudio/learnr/pull/219) [#212](https://github.com/rstudio/learnr/issues/212))

* Question width will expand to the container width. ([#222](https://github.com/rstudio/learnr/pull/222))

Expand Down
32 changes: 1 addition & 31 deletions R/quiz.R
Original file line number Diff line number Diff line change
Expand Up @@ -3,39 +3,9 @@
# X - Allow for null input$answer
## No. If the quiz module wants a null value, it can provide a placeholder value that is not NULL

# √-barret revert to old params names in question
## or deprecate old names and use new names
## double check answer params
# √-barret gut unused R and JS methods from old JS quiz hooks

# √ TODO-barret question / quiz print method
## If a quiz is printed in the console... should it open in the browser or print a list?
## either way it should be document or fixed
# TODO-barret Documentation
# TODO-barret re-render tutorials
# TODO-barret re-render documentation pictures
# √-barret A new question type (“text”)
# TODO-barret You can now extend learnr with your own question types
# TODO-barret Questions are now Shiny apps
# TODO-barret print() behavior is different from before
# TODO-barret R CMD check/rev-dep check
# TODO-barret QA pass (check existing education primers)


# √-barret make the question div a class and data-label combo to be found at render, like an exercise
# √-barret validate that chunk lables do not have unwanted characters to function better on JS side
# √-barret chunk labels are now NS ids
# √-barret use the new label in js to attach the element right away, regardless if it is ready or not
## this allows js to function regardless of state of the quiz question
## this allows for sections to be completed regardless of what is returned from the user





#' Tutorial quiz questions
#'
#' Add interative quiz questions to a tutorial.
#' Add interactive quiz questions to a tutorial.
#' Each quiz question is executed within a shiny runtime to provide more flexibility in the types of questions offered.
#' There are three default types of quiz questions:
#' \describe{
Expand Down
4 changes: 2 additions & 2 deletions R/quiz_print.R
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#' Formatting and printing quizes, questions, and answers
#' Formatting and printing quizzes, questions, and answers
#'
#' Notes:
#' \itemize{
#' \item If custom question types are created, custom s3 formating methods may be implemented as well.
#' \item Due to the shiny runtime of questions, a text representation of quizes, questions, and answers will be presented.
#' \item Due to the shiny runtime of questions, a text representation of quizzes, questions, and answers will be presented.
#' }
#'
#' @param x object of interest
Expand Down
30 changes: 30 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@

## Comments
### 2019-11-08

Please let me know if there is anything I can do.

Thank you,
Barret


## Test environments
* local OS X install, R 3.6.1
* ubuntu 14.04 (on travis-ci), release, oldrel, devel
* win-builder (oldrelease, release, devel)
* R-hub windows-x86_64-release (r-release)
* R-hub windows-x86_64-devel (r-devel)
* R-hub ubuntu-gcc-release (r-release)
* R-hub fedora-clang-devel (r-devel)

## R CMD check results

0 errors ✔ | 0 warnings ✔ | 0 notes ✔


## revdepcheck results

We checked 4 reverse dependencies (3 from CRAN + 1 from BioConductor), comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages
4 changes: 2 additions & 2 deletions man/format_quiz.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/quiz.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions revdep/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
checks
library
checks.noindex
library.noindex
data.sqlite
*.html
23 changes: 23 additions & 0 deletions revdep/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Platform

|field |value |
|:--------|:----------------------------|
|version |R version 3.6.1 (2019-07-05) |
|os |macOS Mojave 10.14.6 |
|system |x86_64, darwin15.6.0 |
|ui |X11 |
|language |(EN) |
|collate |en_US.UTF-8 |
|ctype |en_US.UTF-8 |
|tz |America/New_York |
|date |2019-11-08 |

# Dependencies

|package |old |new |Δ |
|:-------|:-------|:------|:--|
|learnr |0.9.2.1 |0.10.0 |* |
|Rcpp |NA |1.0.2 |* |

# Revdeps

5 changes: 5 additions & 0 deletions revdep/email.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
release_date: ???
rel_release_date: ???
my_news_url: ???
release_version: ???
release_details: ???
1 change: 1 addition & 0 deletions revdep/failures.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*Wow, no problems at all. :)*
1 change: 1 addition & 0 deletions revdep/problems.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*Wow, no problems at all. :)*

0 comments on commit a47a7e0

Please sign in to comment.