Highlight #185
Merged
Highlight #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duplication from template: https://github.com/rstudio/rmarkdown/blob/0ff85d8db1c1b75386cc752062f6016884709139/inst/rmd/h/default.html#L50-L75 document: https://github.com/rstudio/rmarkdown/blob/19008bf684659f8592c5cbd440f9ce7e3786d65a/R/html_document.R#L285-L291 removed code folding as it was not there before
|
One reason we hard-coded this was to match with the Ace editor instances (which also use a textmate style). That said, I see no reason why we shouldn't support everything. |
|
Thank you for the context! I'll keep the default to textmate, but allow you to change it if you'd like. I'll add a documentation item that explains it will only give highlighting color to the R code, not ace editor code. |
|
Okay, sounds good! |
* master: Pass `devtools::check()` (rstudio#186)
schloerke
added a commit
to schloerke/learnr
that referenced
this pull request
Oct 8, 2018
* upstream/master: Highlight code and exercise area (rstudio#185) save metadata information using dput vs deparse (rstudio#190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180
Fixes #150
Copy the latest from rmarkdown for code highlighting. Was defaulting to only texmate highlightjs style. Now allows for all pandoc and textmate style.
Copied from template here:
https://github.com/rstudio/rmarkdown/blob/0ff85d8db1c1b75386cc752062f6016884709139/inst/rmd/h/default.html#L50-L75
Removed code folding as it was not there before
Copied from html_document here: https://github.com/rstudio/rmarkdown/blob/19008bf684659f8592c5cbd440f9ce7e3786d65a/R/html_document.R#L285-L291