Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix progressive reveal and Topics with special characters not loading #330

Merged
merged 4 commits into from
Feb 12, 2020
Merged

Fix progressive reveal and Topics with special characters not loading #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9b6d7e
Make sure to update the js model that the section was skipped
schloerke Feb 11, 2020
5b79832
allow for non ascii chars to be used in hash
schloerke Feb 11, 2020
f1e9f5e
update news
schloerke Feb 11, 2020
e9317c9
Use decodeURIComponent() over decodeURI() when working with just the …
schloerke Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,14 @@ learnr 0.10.0.9000 (unreleased)

* Fixed a bug where broken exercise code created non-"length-one character vector". ([#311](https://github.com/rstudio/learnr/pull/311))

* Fixed extra parameter documentation bug. ([#323](https://github.com/rstudio/learnr/pull/323))
* Fixed extra parameter documentation bug for CRAN. ([#323](https://github.com/rstudio/learnr/pull/323))

* Fixed video initialization error caused by a jQuery version increase in Shiny. ([#326](https://github.com/rstudio/learnr/pull/#326))

* Fixed progressive reveal bug where the next section would not be displayed unless refreshed. ([#330](https://github.com/rstudio/learnr/pull/330))

* Fixed a bug where topics would not be loaded if they contained non-ascii characters. ([#330](https://github.com/rstudio/learnr/pull/330))


learnr 0.10.0
===========
Expand Down
5 changes: 4 additions & 1 deletion inst/rmarkdown/templates/tutorial/resources/tutorial-format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@ $(document).ready(function() {
else {
scrollLastSectionToView = true;
}
// update UI
sectionSkipped([section.jqElement]);
// notify server
tutorial.skipSection(sectionId);
}
}
Expand Down Expand Up @@ -317,7 +320,7 @@ $(document).ready(function() {
function handleLocationHash() {

function findTopicIndexFromHash() {
var hash = window.location.hash;
var hash = window.decodeURIComponent(window.location.hash);
var topicIndex = 0;
if (hash.length > 0) {
$.each(topics, function( ti, t) {
Expand Down