Properly enforce timelimits >= 60s #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an exercise had an assigned timelimit of >= 60s, it would never be reaped. This is because by default when you subtract times it becomes a `difftime` object which will be presented in arbitrary units. Around the 60s mark, you can see we switch from: > str(Sys.time() - start_time) 'difftime' num 58.2525360584259 - attr(*, "units")= chr "secs" to: > str(Sys.time() - start_time) 'difftime' num 1.01057458321253 - attr(*, "units")= chr "mins" When you compare on this time, it compares 1 to your assigned time limit and permits it to continue computing. We need to force the time comparison into seconds in order to accurately compare to our time limit.
schloerke
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an exercise had an assigned timelimit of >= 60s, it would never be reaped. This is because by default when you subtract times it becomes a
difftimeobject which will be presented in arbitrary units. Around the 60s mark, you can see we switch from:to:
When you compare on this time, it compares 1 to your assigned time limit and permits it to continue computing.
We need to force the time comparison into seconds in order to accurately compare to our time limit.