Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pool, flag restored events, resolve requests independently #370

Merged
merged 6 commits into from
May 19, 2020
Merged

Use pool, flag restored events, resolve requests independently #370

merged 6 commits into from
May 19, 2020

Conversation

trestletech
Copy link
Contributor

@trestletech trestletech commented May 14, 2020 •
edited
Loading

  1. use the curl pool that had been created but was going unused. This will allow us to send more than 6 requests to an external evaluator at once.
  2. Includes the restore flag on exercise_submitted events so that we can differentiate restored from interactive events.
  3. Fixes an external evaluator bug in which we were previously waiting for EVERY request to resolve rather than just waiting for a particular request to resolve.

Closes #363

@trestletech
Use the pool to enable sending more than 6 requests at a time
31d0015
@trestletech
Add restore to emitted flags on exercise submit
d6791fd 
TRUE if the exercise is being restored from a previous run, FALSE if it's being run interactively.
@trestletech trestletech changed the title Use pool, flag restored events Use pool, flag restored events, resolve requests independently May 15, 2020
@trestletech trestletech merged commit 8cfa75c into master May 19, 2020
@trestletech trestletech deleted the use-pool branch May 19, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distinguish exercise runs triggered by session creation
2 participants
@trestletech @schloerke