Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix question_is_correct.learnr_text comparison #376

Merged
merged 7 commits into from
Jun 8, 2020
Merged

Conversation

schloerke
Copy link
Collaborator

Fixes #375

Also updated Actions workflow file.

ans$label is an HTML() formatted text string. This will not match. Instead, ans$option should be used as it is the raw value provided by the user.

@schloerke schloerke self-assigned this May 27, 2020
@schloerke schloerke marked this pull request as ready for review May 27, 2020 02:38
Copy link
Contributor

@trestletech trestletech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me, but I haven't touched this part of the code so I'm not confident giving a 👍. Would this function benefit from a quick unit test or two?

Your call. I'm not opposed to this as-is.

@schloerke
Copy link
Collaborator Author

Merging as is. Linked in #383

@schloerke schloerke merged commit cdf7103 into master Jun 8, 2020
@schloerke schloerke deleted the learnr_text branch June 8, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using the type = "learnr_text" argument turns all answers incorrect
2 participants