Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save tutorial output to temp folder when tutorial folder does not have write permissions #412

Merged
merged 4 commits into from
Jul 30, 2020

Conversation

schloerke
Copy link
Collaborator

Fixes #347

Heavily inspired from #387 , but did not receive contact from OP.

PR task list:

  • Update NEWS
  • [NA] Add tests (if possible)
  • [NA] Update documentation with devtools::document()

@schloerke schloerke requested a review from cpsievert July 30, 2020 14:51
@schloerke schloerke mentioned this pull request Jul 30, 2020
2 tasks
NEWS.md Outdated Show resolved Hide resolved
R/run.R Outdated Show resolved Hide resolved
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
@schloerke schloerke merged commit bd29e0c into master Jul 30, 2020
@schloerke schloerke deleted the tutorial_temp_output branch July 30, 2020 18:53
schloerke added a commit that referenced this pull request Aug 7, 2020
* master:
  Disable completion of R code inside quotes, closes #401 (#413)
  Bump version (#414)
  Save tutorial output to temp folder when tutorial folder does not have write permissions (#412)
  Throw an informative error if an exercise chunk is NULL (#411)
  Remove outdated exercise option
  Checking for exercise errors (#403)
schloerke added a commit that referenced this pull request Sep 2, 2020
* master:
  Add events to website (#423)
  Add a checker test with error as solution (#422)
  Fixes for learnr on external evaluator (#420)
  Add shinytest support (#407)
  Validate the ability to create an idb store (#417)
  Disable completion of R code inside quotes, closes #401 (#413)
  Bump version (#414)
  Save tutorial output to temp folder when tutorial folder does not have write permissions (#412)
  Throw an informative error if an exercise chunk is NULL (#411)
  Remove outdated exercise option
  Checking for exercise errors (#403)
  Add event handler system (#398)
  External evaluator fixes (#399)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy tutorial folder to temp folder when calling run_tutorial
2 participants