-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colin/output styles #438
base: main
Are you sure you want to change the base?
Colin/output styles #438
Conversation
… new options, plus added some new options for the new alert mechanism
Co-authored-by: Barret Schloerke <barret@rstudio.com>
…ck_show and exercise.gradethis_code_show are now set to TRUE if exercise$check and exercise$code_check are NULL
…dded when error is returned
@trestletech @schloerke @dcossyleon As of our last discussion, this is now the default behavior:
=> |
Looking good to me! @dcossyleon I can't remember where we netted out in the last meeting, but I notice that in the current demo learnr exercise syntax errors have their output highlighted in an alert background. I think that's helpful since we don't have the ability to print error text in right like we could in the IDE. But I remember you had reservations. Did we decide we did or did not want that? |
The code changes look great! Just a few minor changes left. 😄 |
Originally I had suggested that "Run Code" always give the standard black output, but I agree now that some sort of color indication of an error would indeed be helpful. The colored background feels too bulky for "Run Code" error output, but a nice compromise would be the suggestion of using the colored outline (see below). This is subtle enough that the focus remains on the text in the error message, while still giving a color indication that something went awry. I think the colored background should be saved for |
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@dcossyleon this is implemented in the last commit: |
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Looks great to me |
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
|
This PR implements a new way to customize the outputs from both
{learnr}
and{gradethis}
using exercise options.