-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
question_text() uses textAreaInput() if rows or cols are provided #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
reviewed
Jan 4, 2021
Does this PR address #455? I think we'll hold off on a dedicated Thank you! and Thank you @gadenbuie! |
schloerke
reviewed
Jan 4, 2021
Yes, this does the job. Thanks!
…On Mon, Jan 4, 2021 at 9:23 AM Barret Schloerke ***@***.***> wrote:
cc @dtkaplan <https://github.com/dtkaplan> @davidkane9
<https://github.com/davidkane9>
Does this PR address #455 <#455>?
I think we'll hold off on a dedicated learnr_text_area() function for
now. If you find yourself using a consistent set of rows/cols... please
open a new issue and we can open the discussion to add learnr_text_area()
and default to learnr_text_area(rows = m, cols = n)
Thank you! and Thank you @gadenbuie <https://github.com/gadenbuie>!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#460 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAECBLNXQNGVN2MBLK3VN33SYHMQRANCNFSM4VOSVRMQ>
.
|
schloerke
approved these changes
Jan 5, 2021
Yes. Thanks!
…On Mon, Jan 4, 2021 at 9:23 AM Barret Schloerke ***@***.***> wrote:
cc @dtkaplan <https://github.com/dtkaplan> @davidkane9
<https://github.com/davidkane9>
Does this PR address #455 <#455>?
I think we'll hold off on a dedicated learnr_text_area() function for
now. If you find yourself using a consistent set of rows/cols... please
open a new issue and we can open the discussion to add learnr_text_area()
and default to learnr_text_area(rows = m, cols = n)
Thank you! and Thank you @gadenbuie <https://github.com/gadenbuie>!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#460 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCXREZXK6U7EX3XVPOC77LSYHMQRANCNFSM4VOSVRMQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455
This PR adds
rows
andcols
as parameters ofquestion_text()
. When provided, the text input UI will usetextAreaInput()
instead oftextInput()
.I used
rows
andcols
as the parameter names so we can inherit documentation fromtextAreaInput()
, but I'd be happy to update the parameter names or documentation to specifically mention that they change the input UI.Reprex
Here's an example to try to create an "essay" input as described in #455. The question will always be graded as incorrect, but by setting
allow_retry = TRUE
and changing thetry_again_button
text, the input feels less binary correct/incorrect.PR task list:
devtools::document()