-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally reveal (or hide) exercise solution #470
Merged
gadenbuie
merged 15 commits into
rstudio:master
from
gadenbuie:optionally-reveal-solution
Jan 15, 2021
Merged
Optionally reveal (or hide) exercise solution #470
gadenbuie
merged 15 commits into
rstudio:master
from
gadenbuie:optionally-reveal-solution
Jan 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and tweak documentation a bit
|
The errors are still surfaced by render() and the test should be runnable on CRAN. I included a skip if pandoc isn't available, since if the knit step is successful, pandoc will be called. This also protects against tests where rmarkdown::run() should fail but doesnt, in which case run() will launch the tutorial and run indefinitely.
schloerke
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM given minor changes
|
1. solution chunk option 2. exercise chunk option 3. global knitr chunk option 4. global R option
schloerke
reviewed
Jan 13, 2021
`after` was added in R 3.5
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
exercise.reveal_solution
, which can be set in the*-solution
chunk options or globally withtutorial_options()
ortutorial.exercise.reveal_solution
. IfFALSE
, the solution is not revealed to the user. The local chunk option takes precedence over the global option.Fixes #402
Demo Tutorial
PR task list:
devtools::document()