Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support additional languages for random phrases #538

Merged
merged 20 commits into from
Jun 23, 2021
Merged

Support additional languages for random phrases #538

merged 20 commits into from
Jun 23, 2021

Commits on Jun 11, 2021

  1. Fix spelling of "identifier"

    @gadenbuie
    gadenbuie committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    630ed70 View commit details
    Browse the repository at this point in the history

  2. Connect language option in running tutorial to exercise evaluation 

    - Updating the language in the app sets `tutorial.language` in the request that can be read via `read_request()`
- That language option is added to the `exercise` object in Shiny
- evaluate_exercise() sets the knitr option `tutorial.language` to match that language via `i18n_set_language_option()`
- Exercise code can read the current language via `i18n_get_language_option()`
    @gadenbuie
    gadenbuie committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    2179faa View commit details
    Browse the repository at this point in the history

  3. Migrate older exercises to version 3

    @gadenbuie
    gadenbuie committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    1fcc012 View commit details
    Browse the repository at this point in the history

  4. Move praise and encouragement phrases into a yaml file

    @gadenbuie
    gadenbuie committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    1e18fa4 View commit details
    Browse the repository at this point in the history

  5. Load phrases from internal data and make random phrases language-aware

    @gadenbuie
    gadenbuie committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    441d512 View commit details
    Browse the repository at this point in the history

  6. Set exercise chunk options globally when rendering the exercise 

    Avoids having to make sure that all of the chunk options fit on one line
    @gadenbuie
    gadenbuie committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    0aff7c8 View commit details
    Browse the repository at this point in the history

  7. Add random_phrases_add() helper function

    @gadenbuie
    gadenbuie committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    7088a50 View commit details
    Browse the repository at this point in the history

  8. Update tests to match new exercise version 3

    @gadenbuie
    gadenbuie committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    92c458e View commit details
    Browse the repository at this point in the history

  9. Delete stray #'

    @gadenbuie
    gadenbuie committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    89d55f1 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. Update R/exercise.R 

    Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @gadenbuie @schloerke
    gadenbuie and schloerke authored Jun 14, 2021
    Configuration menu
    Copy the full SHA
    7e50614 View commit details
    Browse the repository at this point in the history

  2. Move tutorial language watcher into helper function

    @gadenbuie
    gadenbuie committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    7327528 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Merged upstream/master into i18n/random-phrases

    @gadenbuie
    gadenbuie committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    f0b789b View commit details
    Browse the repository at this point in the history

  2. Fix small issue in reencode_utf8()

    @gadenbuie
    gadenbuie committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    813df47 View commit details
    Browse the repository at this point in the history

  3. Also reencode random phrases

    @gadenbuie
    gadenbuie committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    2b5dad1 View commit details
    Browse the repository at this point in the history

  4. Add emoji random phrases

    @gadenbuie
    gadenbuie committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    2e66306 View commit details
    Browse the repository at this point in the history

  5. Rename language key debug -> testing

    @gadenbuie
    gadenbuie committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    b5fabfd View commit details
    Browse the repository at this point in the history

  6. Update internal i18n data

    @gadenbuie
    gadenbuie committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    91ee042 View commit details
    Browse the repository at this point in the history

  7. Random phrases should be character vectors in the end

    @gadenbuie
    gadenbuie committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    59a3303 View commit details
    Browse the repository at this point in the history

  8. Update tests after testing lang key change

    @gadenbuie
    gadenbuie committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    c8000ac View commit details
    Browse the repository at this point in the history

  9. Move i18n files to internals/ and add .rds extension

    @gadenbuie
    gadenbuie committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    e57f3f5 View commit details
    Browse the repository at this point in the history