Protect options() from modifications by student or checking code
#542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any other things besides options that need to be protected in this way? |
gadenbuie
requested changes
Jun 21, 2021
|
I've found that the same issue with |
gadenbuie
reviewed
Jun 21, 2021
gadenbuie
requested changes
Jun 23, 2021
There was a problem hiding this comment.
One more little update (see #542 (comment)) and then we'll be good to go. Can you also please add a NEWS item for this PR? Thank you!
…nd `render_exercise()`
|
@rossellhayes I added two tests that also check that the checking code doesn't end up modifying the options or env vars. Do you think we've covered all of our bases in the tests? |
|
Good thinking! That all seems good to me, I can't think of anything that's missing |
gadenbuie
changed the title
options() from modifications by studentsoptions() from modifications by student or checking code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies
evaluate_exercise()to capture the state ofoptions()when the tutorial is first loaded. This snapshot is restored each time an exercise is run. This allows tutorial authors to still set options in thesetupchunk. Students can modify options within a chunk, but these options are not carried over to later chunks or subsequent runs of the same chunk.