Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n_set_language_option() sets env var to translate R messages #558

Merged
merged 18 commits into from
Jul 28, 2021

Conversation

rossellhayes
Copy link
Contributor

This PR expands i18n_set_language_option(). In addition to setting a knitr option to translate the learnr interface, it will also now set an environment variable to translate R messages. This will allow users to receive feedback from R, including gradethis feedback, in their own language (when translations are available).

tests/testthat/test-i18n.R Outdated Show resolved Hide resolved
tests/testthat/test-i18n.R Outdated Show resolved Hide resolved
tests/testthat/test-i18n.R Outdated Show resolved Hide resolved
R/i18n.R Outdated Show resolved Hide resolved
R/i18n.R Outdated Show resolved Hide resolved
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Pending small changes and a NEWS entry this is ready to go 🚀

R/i18n.R Outdated Show resolved Hide resolved
R/i18n.R Outdated Show resolved Hide resolved
R/i18n.R Outdated Show resolved Hide resolved
R/i18n.R Outdated Show resolved Hide resolved
R/i18n.R Outdated Show resolved Hide resolved
R/i18n.R Outdated Show resolved Hide resolved
rossellhayes and others added 2 commits July 28, 2021 14:16
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
@gadenbuie gadenbuie merged commit f260faa into rstudio:master Jul 28, 2021
@rossellhayes rossellhayes deleted the i18n-env-var branch August 4, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants