Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bs4+ popover 'dispose' method #560

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Support bs4+ popover 'dispose' method #560

merged 2 commits into from
Jul 27, 2021

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Jul 27, 2021 •
edited
Loading

Correct issue in comment: #468 (comment)

PR task list:

  • Update NEWS
  • [NA] Add tests (if possible)
  • [NA] Update documentation with devtools::document()

@schloerke schloerke marked this pull request as ready for review July 27, 2021 15:50
@schloerke schloerke requested a review from gadenbuie July 27, 2021 15:51
@schloerke
Copy link
Collaborator Author

cc @rjknell

gadenbuie
gadenbuie approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3️⃣ ➕ 4️⃣

@schloerke schloerke changed the title Support bs4+ popover dispose method Support bs4+ popover 'dispose' method Jul 27, 2021
@schloerke schloerke merged commit d20da03 into master Jul 27, 2021
@schloerke schloerke deleted the bs4_popover branch July 27, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadenbuie gadenbuie gadenbuie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schloerke @gadenbuie