-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hand off parse error to error checker if one is available #596
Conversation
also duplicated in log messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
- Internal error helper emits log messages via `message()` and an error exercise result with specificl language - `render_exercise()` catches setup and user code errors but returns an internal error if the error comes from the setup chunk(s) - The error condition of internal errors is returned under `$feedback$error` - Pass the original user code error to the error checker, rather than the wrapped error we use to signal the issue
I added a few more changes that overhaul internal errors in learnr and to make sure that errors caused by exercise setup chunks aren't treated like user-generated errors:
|
Just to clarify f0c6366, warnings will show up in the console but not in the |
Yup, that's emitted either in the Shiny server or in the logs of the external evaluator |
global_setup
inevaluate_exercise()
are now returned as internal errorsexercise.error.check.code
intoerror_check
, instead we do that operation when we actually go to evaluate the error checker. This lets us tell the difference between a global default option and an explicit error checker.