Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Python and additional exercise engine support #724

Merged
merged 27 commits into from
Aug 29, 2022
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
87f9c17
feat: prep and pass envirs for python exercise checking
nischalshrestha Jun 16, 2022
918b3bf
chore: Suggest {reticulate}
gadenbuie Aug 4, 2022
4b4f67a
feat: exercise version 4 now includes the exercise engine as a class
gadenbuie Aug 4, 2022
c12d974
fix: protect against NULL where environment is expected
gadenbuie Aug 4, 2022
5fb297c
feat: Use classes to `prepare_exercise()`
gadenbuie Aug 4, 2022
a3ac618
feat: Use classes to generate `exercise_code_chunks_user_rmd()`
gadenbuie Aug 4, 2022
a0faae1
feat: Use classes for `render_exercise_result()`
gadenbuie Aug 4, 2022
2380642
chore: Rename `render_exercise_prepare()`
gadenbuie Aug 4, 2022
4d8cf2c
chore: Rename `render_exercise_rmd_user()`
gadenbuie Aug 4, 2022
4a8563d
feat: Add `render_exercise_rmd_prep()` generic
gadenbuie Aug 4, 2022
e4200b6
chore: simplify `render_exercise_prepare.python()`
gadenbuie Aug 4, 2022
146c61a
chore: add `py_global_env()`
gadenbuie Aug 4, 2022
ccb711a
feat: `render_exercise_post_stage_hook()`
gadenbuie Aug 4, 2022
6967b71
feat: `render_exercise_post_stage_hook()`
gadenbuie Aug 4, 2022
5f8d3bf
chore: don't export py env helper functions
gadenbuie Aug 4, 2022
787ce5c
docs: Don't document internal py tools
gadenbuie Aug 4, 2022
b66eb2d
fix: solution chunk uses same engine as exercise
gadenbuie Aug 4, 2022
c9231b2
chore: Remove `module` argument of `clear_py_env()`
gadenbuie Aug 4, 2022
2eacef6
tests: Add python exercise tests
gadenbuie Aug 4, 2022
8c67492
chore: fix typo in comments
gadenbuie Aug 4, 2022
9e3ade9
chore(style): `render_exercise_result()`
gadenbuie Aug 4, 2022
8b79820
chore(clear_py_env): update description comments
gadenbuie Aug 4, 2022
cafe3fb
chore: one more small function arg re-ordering
gadenbuie Aug 5, 2022
bc64e57
fix: ensure exercise object class is preserved when joining with the …
gadenbuie Aug 5, 2022
d672425
chore: Be very very certain exercise object has the right classes
gadenbuie Aug 5, 2022
9a9fa96
Apply suggestions from code review
gadenbuie Aug 9, 2022
f8b625a
chore(NEWS): Add item for #724
gadenbuie Aug 29, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ Suggests:
DBI (>= 0.4-1),
httpuv,
later,
reticulate,
RSQLite,
rstudioapi (>= 0.11),
shinytest2,
Expand Down
12 changes: 12 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,18 @@ S3method(question_ui_initialize,learnr_numeric)
S3method(question_ui_initialize,learnr_radio)
S3method(question_ui_initialize,learnr_text)
S3method(question_ui_try_again,default)
S3method(render_exercise_post_stage_hook,default)
S3method(render_exercise_post_stage_hook,python)
S3method(render_exercise_prepare,default)
S3method(render_exercise_prepare,python)
S3method(render_exercise_prepare,sql)
S3method(render_exercise_result,default)
S3method(render_exercise_result,python)
S3method(render_exercise_result,sql)
S3method(render_exercise_rmd_prep,default)
S3method(render_exercise_rmd_user,default)
S3method(render_exercise_rmd_user,python)
S3method(render_exercise_rmd_user,sql)
export(answer)
export(answer_fn)
export(available_tutorials)
Expand Down
Loading