-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require markdown >= 1.3 and update usage #745
Conversation
This function will be removed in a future version of **markdown**.
using options = 'fragment_only` will be equivalent to `fragment.only = TRUE`
[ci skip]
Thanks @yihui, is this ready for review? |
…instead of using the deprecated option `fragment_only` (the `mathjax` option is enabled by default, so no need to specify it)
I just made a new release of the markdown package to CRAN the other day. This PR is ready to merge now (after it passes the checks). Thanks! |
@yihui First, I really appreciate the complete PR and for making the transition easy! That said, I'm looking at learnr's single use of |
Good question. The commonmark package is basically a bare minimal version of Markdown, and the markdown package supports a few extra features such as LaTeX math, base64 encoding images, super/subscripts, etc. If you don't need these extra features, you can definitely just call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @yihui! And thank you for clarifying – we'll stick with {markdown} for now.
* Stop importing markdown::markdownExtensions() This function will be removed in a future version of **markdown**. * The extensions and fragment.only arguments will be removed, too using options = 'fragment_only` will be equivalent to `fragment.only = TRUE` * Update learnr-package.R [ci skip] * no need to import in namespace; just use `markdown::markdownToHTML()` * require markdown >= 1.3, and call mark_html(options = '-standalone') instead of using the deprecated option `fragment_only` (the `mathjax` option is enabled by default, so no need to specify it) * add news
This function will be removed in a future version of markdown.
I'll let you know when this PR is ready to merge. Thanks!
PR task list:
devtools::document()