Skip non-ASCII tests if system does not support UTF-8 #749
Conversation
rossellhayes
added
the
type: bug
rossellhayes
changed the title
…h a non-ASCII character string and one test with a non-ASCII variable name * Non-ASCII character strings should work on all platforms * Non-ASCII variable names should only work on platforms with UTF-8 support
|
Okay, I've done some investigating on a non-UTF-8 Windows build, and here's what's going on: The failing test involves the This particular failing test occurred in a case where the code contains non-ASCII character but shouldn't return an error: it assigned a non-ASCII character vector to a non-ASCII (Greek) variable name, which is a valid operation. However, non-ASCII variable names can only be used on platforms with UTF-8 support. To fix this, I've split the test into two tests. The non-ASCII character vector is tested on all platforms: it shouldn't produce a parse error on any system, since you can use Unicode characters in strings even on non-UTF-8 platforms. The non-ASCII variable name is now only tested on non-Windows platforms with UTF-8 support, since that will cause a parse error on non-UTF-8 systems. I've tested this locally on Windows R 3.6.3 (no UTF-8 support) and non-UTF-8 Debian on R-hub with no errors. |
* fix: skip non-ASCII tests is system does not support UTF-8 * test(exercise_check_unparsable_unicode): split test into one test with a non-ASCII character string and one test with a non-ASCII variable name * Non-ASCII character strings should work on all platforms * Non-ASCII variable names should only work on platforms with UTF-8 support
Previously, tests that involved non-ASCII text were skipped on Windows, with the assumption that all Unix builds of R support UTF-8. Tests now explicitly check if the system supports UTF-8 to avoid a CRAN failure on non-Unicode Unix builds. This fix is confirmed working on rhub's debian-clang-devel platform, which forces a Latin-1 (non-UTF-8) locale.
Closes #748.