Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tab size in Ace editor to 2 #761

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Set tab size in Ace editor to 2 #761

merged 4 commits into from
Feb 21, 2023

Conversation

rossellhayes
Copy link
Contributor

The Ace editor used in learnr tutorials defaults to using 4 spaces for tabs, but Tidyverse style recommends two spaces.

@gadenbuie I think I made the needed change in tutorial.js, but I'm not sure how build.js works, could you help me out with that part?

@rossellhayes rossellhayes self-assigned this Feb 16, 2023
npm install
npm run build
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! To update the learnr javascript resources you can run the following in the Terminal in the learnr repo:

# install the required js libraries (call once)
npm install

# re-build learnr's js sources
npm run build

@rossellhayes rossellhayes marked this pull request as ready for review February 21, 2023 16:58
@rossellhayes rossellhayes merged commit b6669f9 into main Feb 21, 2023
@rossellhayes rossellhayes deleted the fix/setTabSize branch February 21, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants