-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give better hint for checkbox questions created with question()
in try_again
message
#783
Conversation
…tions than radio questions
Can you explain a bit more about the decision to add a new argument? |
@gadenbuie Because An alternative solution would be to change the default value of |
Yeah, that would be better. When you call |
…value of `NULL` Move logic to determine default message inside the function
That makes sense, refactored in 316d85f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great, thanks!
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
This PR extends #732 to apply to checkbox questions created by
question()
in addition to checkbox questions created byquestion_checkbox()
. It does this by changing the default value oftry_again
inquestion()
toNULL
. Iftry_again
isNULL
,question()
determines the default message based on the questiontype
.Closes #782.