Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty repository field #569

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

kenahoo
Copy link
Contributor

@kenahoo kenahoo commented Aug 1, 2019

Addresses issue #528

@kenahoo
Copy link
Contributor Author

kenahoo commented Aug 2, 2019

I'm not sure what the test failures are about - in my local environment, a huge number of tests fail spectacularly both before & after the patch so I'm not sure if the new code is responsible for it or not.

@kevinushey
Copy link
Contributor

I'll try to review and figure out what's going on next week.

@kenahoo
Copy link
Contributor Author

kenahoo commented Aug 2, 2019

Thanks, appreciated.

@kevinushey
Copy link
Contributor

Hi @kenahoo -- thanks for your patience. This PR looks good to me, and I think the Travis failures are unrelated.

For contributions to RStudio's open source projects, we do require a contributor license agreement -- would you mind filling that out and sending it to the e-mail indicated in the form?

Once we have that on file I'll be happy to merge this PR. Thanks!

@kenahoo
Copy link
Contributor Author

kenahoo commented Aug 7, 2019

@kevinushey Sure, I can do that - I thought I'd done this before, though, any way to check whether I'm already "in the system"?

@kevinushey
Copy link
Contributor

We do maintain a database of signed CLAs, but I didn't see your name in there -- if you have signed one before and it just wasn't added for some reason, I apologize. Would you be willing to file a new one in any case?

@kenahoo
Copy link
Contributor Author

kenahoo commented Aug 7, 2019

Yup - just making sure I push it through the right channels at my company, I hope to have it back today or tomorrow.

@kevinushey
Copy link
Contributor

Sounds good -- thanks for your patience.

@kenahoo
Copy link
Contributor Author

kenahoo commented Aug 7, 2019

Hey @kevinushey , I think we probably want to use the https://www.rstudio.com/wp-content/uploads/2014/06/RStudioCorporateContributorAgreement.pdf in this case, since I did this on "company time" while working on some deployment stuff for an internal application, sound correct? Company is NextEra Analytics (formerly known as WindLogics).

@kevinushey
Copy link
Contributor

That sounds correct to me.

@kenahoo
Copy link
Contributor Author

kenahoo commented Aug 8, 2019

I've sent the signed agreement document to JJ.

@kevinushey kevinushey merged commit 4dcd0b0 into rstudio:master Aug 9, 2019
@kevinushey
Copy link
Contributor

Thanks! We've received the CLA; I'll merge this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants