-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty repository field #569
Conversation
I'm not sure what the test failures are about - in my local environment, a huge number of tests fail spectacularly both before & after the patch so I'm not sure if the new code is responsible for it or not. |
I'll try to review and figure out what's going on next week. |
Thanks, appreciated. |
Hi @kenahoo -- thanks for your patience. This PR looks good to me, and I think the Travis failures are unrelated. For contributions to RStudio's open source projects, we do require a contributor license agreement -- would you mind filling that out and sending it to the e-mail indicated in the form? Once we have that on file I'll be happy to merge this PR. Thanks! |
@kevinushey Sure, I can do that - I thought I'd done this before, though, any way to check whether I'm already "in the system"? |
We do maintain a database of signed CLAs, but I didn't see your name in there -- if you have signed one before and it just wasn't added for some reason, I apologize. Would you be willing to file a new one in any case? |
Yup - just making sure I push it through the right channels at my company, I hope to have it back today or tomorrow. |
Sounds good -- thanks for your patience. |
Hey @kevinushey , I think we probably want to use the https://www.rstudio.com/wp-content/uploads/2014/06/RStudioCorporateContributorAgreement.pdf in this case, since I did this on "company time" while working on some deployment stuff for an internal application, sound correct? Company is NextEra Analytics (formerly known as WindLogics). |
That sounds correct to me. |
I've sent the signed agreement document to JJ. |
Thanks! We've received the CLA; I'll merge this now. |
Addresses issue #528