pin_write() does not always return fully qualified path as documented

[juliasilge]

As @jonthegeek points out in #646 object_write() does not always return the path. Sometimes it returns the object.

[juliasilge]

Wait, is this wrong? It does always return the path, doesn't it?

pins-r/R/pin-read-write.R

Line 135 in b8ea052

path

Maybe we should write a couple of tests of what pin_write() returns.

[jonthegeek]

Huh, I think I misread it. I thought it was returning what the sub-function returns, but it ignores that... so I think you're all set!

[juliasilge]

We actually are testing this, via the local_pin() function:

pins-r/R/testthat.R

Line 2 in b8ea052

name <- pin_write(board, value, random_pin_name(), ...)

That function is called in all the tests that run across boards, including the metadata tests like test_api_meta(). We are definitely good to go. 👍

[github-actions]

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.