Move arrow to suggests. #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rstudio#644. Note: writing to arrow was previously returning the object (invisibly), rather than the fully qualified path (invisibly) like the help says. It now returns the path. As far as I can tell, no tests check this. I think json and csv likely return the object, but I haven't dug in to confirm.
juliasilge
reviewed
Aug 26, 2022
juliasilge
approved these changes
Aug 26, 2022
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #644.
Note: writing to arrow was previously returning the object (invisibly), rather than the fully qualified path (invisibly) like the help says. It now returns the path. As far as I can tell, no tests check this. I think json and csv likely return the object, but I haven't dug in to confirm.