Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug CI failures #441

Merged
merged 8 commits into from
Apr 30, 2021
Merged

Debug CI failures #441

merged 8 commits into from
Apr 30, 2021

Conversation

hadley
Copy link
Member

@hadley hadley commented Apr 29, 2021

No description provided.

@hadley
Copy link
Member Author

hadley commented Apr 29, 2021

Thanks to @gaborcsardi's investigation the bug comes from writing Latin1; need to re-encoded all character elements with enc2utf8()

@hadley
Copy link
Member Author

hadley commented Apr 29, 2021

to_utf8 <- function(x) {
  if (is.list(x)) {
    names(x) <- enc2utf8(x)
    lapply(x, to_utf8)
  } else if (is.character(x)) {
    enc2utf8(x)
  } else {
    x
  }
}

@hadley
Copy link
Member Author

hadley commented Apr 29, 2021

Root cause: vubiostat/r-yaml#90

@hadley hadley merged commit 6444962 into master Apr 30, 2021
@juniperlsimonis
Copy link

Root cause: viking/r-yaml#90

thank you for linking this, having a similar issue with a package i'm working on and trying to track down why it was crashing

@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants