Can't writeBin without removing filename attribute when using a file parameter

[meztez]

writeBin does not like the raw vector to have attributes (in this case filename)

#* @apiTitle Upload test

#* @param pdf:file
#* @post /upload
function(pdf) {
  f <- tempfile()
  on.exit(unlink(f), add = TRUE)
  writeBin(pdf, tempfile())
  class(pdf)
}

#* @param pdf:file
#* @post /upload2
function(pdf) {
  f <- tempfile()
  on.exit(unlink(f), add = TRUE)
  writeBin(as.raw(pdf), tempfile())
  class(pdf)
}

#* @param pdf:file
#* @post /upload3
function(pdf) {
  f <- tempfile()
  on.exit(unlink(f), add = TRUE)
  attr(pdf, "filename") <- NULL
  writeBin(pdf, tempfile())
  class(pdf)
}

upload : Error in writeBin(pdf, tempfile()): can only write vector objects
upload2 and upload3 : ok

Should we fix or document use case?

If fix:
a) remove attributes
b) return a named list of bytes list(filename = bytesVector); comes with testing what filename constitute a valid R name.
c) other option that comes down to where does filename should live during execution

[schloerke]

I like the solution of /upload2. I also like the idea of list(filename = rawVec) as it extends to multi-file upload as well. If no name is provided, then we can do list(rawVec).

(** Asking team)

[schloerke]

list(filename = bytesVector) feels much cleaner. Waiting for more feedback.

[meztez]

PR incoming

[schloerke]

Thank you @meztez . I think the list(filename = bytesVector) is the better approach.

This will make multipart forms much easier as well. (list(f1 = val1, f2 = val2))

(Great catch!)

[schloerke]

Fixed in #636